Skip to content

Conversation

@Vinzent03
Copy link
Collaborator

@Vinzent03 Vinzent03 commented Mar 25, 2025

What kind of change does this PR introduce?

mainly: run supabase_flutter test on web
but I've noticed several other issues and fixed them as well

What is the current behavior?

We only test for the vm version, but not the web version. We do build the example app for web, but this does not catch runtime errors.

What is the new behavior?

Additional context

For now, I've only added it to ci for supabase_flutter as I'm somehow not able to do http requests. Neither to localhost nor to something like google. I'm pretty sure CORS is not the reason, but I couldn't find the reason.

@coveralls
Copy link

coveralls commented Mar 25, 2025

Pull Request Test Coverage Report for Build 14071151669

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 75.426%

Files with Coverage Reduction New Missed Lines %
packages/supabase_flutter/lib/src/supabase_auth.dart 2 56.31%
Totals Coverage Status
Change from base Build 14063438297: -0.05%
Covered Lines: 2836
Relevant Lines: 3760

💛 - Coveralls

@Vinzent03 Vinzent03 changed the title test: support web test for supabase_flutter test: Support web test for supabase_flutter Mar 25, 2025
@Vinzent03 Vinzent03 changed the title test: Support web test for supabase_flutter test: Run test for supabase_flutter on web as well Mar 25, 2025
@Vinzent03 Vinzent03 marked this pull request as ready for review March 25, 2025 22:22
@Vinzent03 Vinzent03 requested a review from dshukertjr March 25, 2025 22:22
@Vinzent03 Vinzent03 merged commit 6a86752 into main Mar 26, 2025
8 checks passed
@Vinzent03 Vinzent03 deleted the test/web branch March 26, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants